kgyrtkirk commented on a change in pull request #1286:
URL: https://github.com/apache/hive/pull/1286#discussion_r569557253
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java
##########
@@ -654,11 +655,18 @@ public static String findTableColNameOf(Operator<?>
start, String internalColNam
continue;
}
// If columnName is the output of a ColumnExpr get the original
columnName from the Expr Map
- if (currentOp.getColumnExprMap() != null &&
currentOp.getColumnExprMap().containsKey(internalColName)
- && currentOp.getColumnExprMap().get(internalColName) instanceof
ExprNodeColumnDesc) {
- internalColName = ((ExprNodeColumnDesc)
currentOp.getColumnExprMap().get(internalColName)).getColumn();
+ if (currentOp.getColumnExprMap() != null &&
currentOp.getColumnExprMap().containsKey(internalColName)) {
+ // Only use colInfo that is ExprNodeColumnDesc (could even be a UDF on
the key at this point)
+ if (currentOp.getColumnExprMap().get(internalColName) instanceof
ExprNodeColumnDesc) {
+ internalColName = ((ExprNodeColumnDesc)
currentOp.getColumnExprMap().get(internalColName)).getColumn();
+ keyColInfo = currentOp.getSchema().getColumnInfo(internalColName);
Review comment:
this method somewhat reminds me to the `backtrack` methods we have in
the `ExprNodeDescUtils` class - I don't know if you will find a perfect match ;
but might worth to take a look at them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
