pgaref commented on a change in pull request #1286:
URL: https://github.com/apache/hive/pull/1286#discussion_r578636427
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java
##########
@@ -120,7 +120,7 @@ public Object process(Node nd, Stack<Node> stack,
NodeProcessorCtx procCtx,
String outputColumnName = cSELOutputColumnNames.get(i);
ExprNodeDesc cSELExprNodeDesc = cSELColList.get(i);
ExprNodeDesc newPSELExprNodeDesc =
- ExprNodeDescUtils.backtrack(cSELExprNodeDesc, cSEL, pSEL,
true);
+ ExprNodeDescUtils.backtrack(cSELExprNodeDesc, cSEL, pSEL,
true, false);
Review comment:
sure, done
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java
##########
@@ -362,26 +362,26 @@ public static boolean isDeterministic(ExprNodeDesc desc) {
*/
public static ArrayList<ExprNodeDesc> backtrack(List<ExprNodeDesc> sources,
Operator<?> current, Operator<?> terminal) throws SemanticException {
- return backtrack(sources, current, terminal, false);
+ return backtrack(sources, current, terminal, false, false);
}
public static ArrayList<ExprNodeDesc> backtrack(List<ExprNodeDesc> sources,
- Operator<?> current, Operator<?> terminal, boolean foldExpr) throws
SemanticException {
- ArrayList<ExprNodeDesc> result = new ArrayList<ExprNodeDesc>();
+ Operator<?> current, Operator<?> terminal, boolean foldExpr, boolean
skipRSParent) throws SemanticException {
Review comment:
sure, renamed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
