pvargacl commented on a change in pull request #2020:
URL: https://github.com/apache/hive/pull/2020#discussion_r582835527
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -1129,14 +1129,17 @@ public void createTable(Table tbl, boolean ifNotExists,
principalPrivs.setRolePrivileges(grants.getRoleGrants());
tTbl.setPrivileges(principalPrivs);
}
+ if (HiveConf.getBoolVar(conf,
ConfVars.HIVE_TXN_LOCKLESS_READS_ENABLED) &&
AcidUtils.isTransactionalTable(tbl)) {
Review comment:
i would consider do this for every transactional table, regardless of
the config. So we would have consistent naming convention everywhere + it would
help I think it would help reduce the cases to consider (like what happens if
the config is on for some time, then it is turn off, or if somebody turns this
off in session level etc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
