pvargacl commented on a change in pull request #2020:
URL: https://github.com/apache/hive/pull/2020#discussion_r582841704
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -2863,6 +2862,10 @@ private boolean drop_table_core(final RawStore ms, final
String catName, final S
deletePartitionData(partPaths, ifPurge,
ReplChangeManager.shouldEnableCm(db, tbl));
// Delete the data in the table
deleteTableData(tblPath, ifPurge, ReplChangeManager.shouldEnableCm(db,
tbl));
+ } else if (TxnUtils.isTransactionalTable(tbl)) {
+ CompactionRequest rqst = new CompactionRequest(dbname, name,
CompactionType.MAJOR);
Review comment:
This is here to prepare for the Cleaner right?
I think it would be enough to put a record in "ready for cleaning" state
And you would need to pass to location I guess.
Plus you don't need to to this if the data was purged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
