pvary commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r639485639
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -556,15 +593,18 @@ public void testCTASFailureRollback() throws IOException {
testTables.createTable(shell, "source",
HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA,
fileFormat, HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS);
- try {
- shell.executeStatement(String.format("CREATE TABLE target STORED BY '%s'
AS SELECT * FROM source",
- HiveIcebergStorageHandler.class.getName()));
- } catch (Exception e) {
- // expected error
- }
+ String[] partitioningSchemes = {"" /* unpartitioned */, "PARTITIONED BY
(dept)"};
Review comment:
Maybe test for multiple partition columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
