marton-bod commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r640513343
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -151,7 +152,23 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
private void createTableForCTAS(Configuration configuration, Properties
serDeProperties) {
serDeProperties.setProperty(TableProperties.ENGINE_HIVE_ENABLED, "true");
serDeProperties.setProperty(InputFormatConfig.TABLE_SCHEMA,
SchemaParser.toJson(tableSchema));
+
+ // build partition spec, if any
+ if (serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS) !=
null) {
+ String[] partCols =
serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS).split(",");
Review comment:
That's a good question. Elsewhere in the code when parsing the list of
columns from the props, they do the same thing and simply split the list by `,`
- but I guess that's no guarantee by itself. I'll try to find out what
restrictions there are for column naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
