ashish-kumar-sharma commented on a change in pull request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r642039659



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -1266,7 +1309,7 @@ public Table getTable(String catName, String dbName, 
String tblName, String vali
     catName = normalizeIdentifier(catName);
     dbName = StringUtils.normalizeIdentifier(dbName);
     tblName = StringUtils.normalizeIdentifier(tblName);
-    if (!shouldCacheTable(catName, dbName, tblName) || (canUseEvents && 
rawStore.isActiveTransaction())) {
+    if (shouldGetTableFromRawStore(catName, dbName, tblName, validWriteIds)) {

Review comment:
       I will do that in new PR. Where I will put tableId and writeId check on 
all the methods in cacheStore. This PR is mostly around adding validWriteIdList 
to TableWrapper Object in cacheStore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to