sankarh commented on a change in pull request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r648497223
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -918,6 +938,29 @@ private void updateAllTableConstraints(RawStore rawStore,
String catName, String
}
}
+ private void updateValidWriteIdList(TxnStore txnStore, String catName,
String dbName, String tblName) {
+ catName = StringUtils.normalizeIdentifier(catName);
+ dbName = StringUtils.normalizeIdentifier(dbName);
+ tblName = StringUtils.normalizeIdentifier(tblName);
+ LOG.debug("CachedStore: updating cached table validWriteIdlist for
catalog: {}, database: {}, table: {}", catName,
+ dbName, tblName);
+ ValidWriteIdList validWriteIdList = null;
+ try {
+ Deadline.startTimer("getValidWriteIds");
+ validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(txnStore.getValidWriteIds(
Review comment:
AFAIK, we are targeting strict consistency with "Synchronized metastore
cache" work. Eventual consistency is supported even today with regular refresh
of cache with the interval of 1 min. Pls recheck this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
