pgaref commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r647504478



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
       poolLock.lock();
       try {
         while ((result = pool.poll()) == null) {
-          notEmpty.await(100, TimeUnit.MILLISECONDS);
+          LOG.info("Awaiting Tez session to become available in session pool");
+          notEmpty.await(10, TimeUnit.SECONDS);

Review comment:
       Any chance this change can increase the time we actually wait to get a 
session from the pool assuming there is none currently available?
   It looks to me that if the next session becomes available in the next 10ms 
with the new change we might wait 10s instead -- am I missing something ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to