belugabehr commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r647514577



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
       poolLock.lock();
       try {
         while ((result = pool.poll()) == null) {
-          notEmpty.await(100, TimeUnit.MILLISECONDS);
+          LOG.info("Awaiting Tez session to become available in session pool");
+          notEmpty.await(10, TimeUnit.SECONDS);

Review comment:
       @pgaref This is not just a loop-and-sleep.  The `notEmpty` condition 
will be alerted when a session becomes available and this thread will run again 
to pickup the session.  I don't really understand why there is a timeout 
currently implemented.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to