saihemanth-cloudera commented on a change in pull request #2559: URL: https://github.com/apache/hive/pull/2559#discussion_r684404883
########## File path: data/scripts/derby/q_test_extDB_init.derby.sql ########## @@ -0,0 +1,27 @@ +-- reference: https://medium.com/swlh/getting-started-with-apache-derby-9f6ca8dea873 + +create table country (name char(30) not null unique); +create table state (name char(30) not null unique, + country_code int not null); +create table city (name char(30) not null unique, Review comment: create table if not exists table_name? I suggesting this because tables might not get dropped/created properly in a container, it might lead to flaky tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
