saihemanth-cloudera commented on a change in pull request #2559:
URL: https://github.com/apache/hive/pull/2559#discussion_r684407471
##########
File path: itests/qtest/pom.xml
##########
@@ -477,6 +477,23 @@
</profiles>
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <version>1.3.0</version>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <configuration>
+
<url>http://downloads.mariadb.com/Connectors/java/connector-java-2.2.0/mariadb-java-client-2.2.0.jar</url>
+ <outputFileName>mariadb-java-client-2.2.0.jar</outputFileName>
Review comment:
I think it would be nice to not hard-code the versions of connectors.
Can we use place holders instead? check above on how we manage versions for
dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
