dantongdong commented on a change in pull request #2559: URL: https://github.com/apache/hive/pull/2559#discussion_r686159786
########## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/DerbyExternalDB.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.ql.externalDB; + +/** + * MySQLExternalDB is a extension of abstractExternalDB + * Designed for MySQL external database connection + */ +public class DerbyExternalDB extends AbstractExternalDB { + + public DerbyExternalDB() { + super("derby"); + setJdbcUrl(getContainerHostAddress()); + setJdbcDriver(); + } + + public void setJdbcUrl(String hostAddress) { + this.url = String.format("jdbc:derby:memory:%s;create=true", dbName); + } + + public void setJdbcDriver() { + this.driver = "org.apache.derby.jdbc.EmbeddedDriver"; + } + + public String getDockerImageName() { return null; } + + public String[] getDockerAdditionalArgs() { return null; } + + public boolean isContainerReady(ProcessResults pr) { return true; } Review comment: Oh sorry I didn't know derby has server mode too. When testing metastore initialization, the test infrastructure uses embedded mode so I just assumed it does not support server mode([Derby.java](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java)). I will remove this file entirely since it does not support derby currently. I will add it back for later patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
