dantongdong commented on a change in pull request #2559: URL: https://github.com/apache/hive/pull/2559#discussion_r686430649
########## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.ql.externalDB; + +import sqlline.SqlLine; + +import org.apache.commons.io.output.NullOutputStream; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.io.BufferedReader; +import java.io.InputStreamReader; +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.FileReader; +import java.io.InputStream; +import java.io.OutputStream; +import java.io.PrintStream; +import java.io.IOException; +import java.net.URI; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; + +import org.apache.commons.lang3.StringUtils; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * abstractExternalDB is incharge of connect to and populate externaal database for qtest + */ +public abstract class AbstractExternalDB { + protected static final Logger LOG = LoggerFactory.getLogger("AbstractExternalDB"); + + protected static final String userName = "qtestuser"; + protected static final String password = "qtestpassword"; + protected static final String dbName = "qtestDB"; + + public String externalDBType = "derby"; // default: derby + protected String url = String.format("jdbc:derby:memory:%s;create=true", dbName); // defualt: dervy + protected String driver = "org.apache.derby.jdbc.EmbeddedDriver"; // default: derby + private static final int MAX_STARTUP_WAIT = 5 * 60 * 1000; + + public static class ProcessResults { + final String stdout; + final String stderr; + final int rc; + + public ProcessResults(String stdout, String stderr, int rc) { + this.stdout = stdout; + this.stderr = stderr; + this.rc = rc; + } + } + + public static AbstractExternalDB initalizeExternalDB(String externalDBType) throws IOException { + AbstractExternalDB abstractExternalDB; + switch (externalDBType) { + case "mysql": + abstractExternalDB = new MySQLExternalDB(); + break; + case "derby": + abstractExternalDB = new DerbyExternalDB(); + break; + case "postgres": + abstractExternalDB = new PostgresExternalDB(); + break; + default: + throw new IOException("unsupported external database type: " + externalDBType); + } + return abstractExternalDB; + } + + public AbstractExternalDB(String externalDBType) { + this.externalDBType = externalDBType; + } + + protected String getDockerContainerName() { + return String.format("qtestExternalDB-%s", externalDBType); + } + + private String[] buildRunCmd() { + List<String> cmd = new ArrayList<>(4 + getDockerAdditionalArgs().length); + cmd.add("docker"); + cmd.add("run"); + cmd.add("--rm"); + cmd.add("--name"); + cmd.add(getDockerContainerName()); + cmd.addAll(Arrays.asList(getDockerAdditionalArgs())); + cmd.add(getDockerImageName()); + return cmd.toArray(new String[cmd.size()]); + } Review comment: By docker things, do you mean we can reuse some of its functions or reuse the entire infrastructure to launch docker? Most of the test driver infrastructure is very similar to what we have in DatabaseRule, but there are some small things that are different. If we are to use the existing docker things in here, the existing metastore/dbinstall may need some fine-tuning. I don't want to break our existing test infrastructure so I created another version of the fine-tuned docker launching. With that information at hand, do you think it is better to continue with current version of the docker launching, or fine-tune what we had in DatabaseRule to adjust this new test infrastructure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
