abstractdog commented on a change in pull request #2479:
URL: https://github.com/apache/hive/pull/2479#discussion_r690422532
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedListColumnReader.java
##########
@@ -193,59 +190,59 @@ private List
decodeDictionaryIds(PrimitiveObjectInspector.PrimitiveCategory cate
case SHORT:
resultList = new ArrayList<Integer>(total);
for (int i = 0; i < total; ++i) {
- resultList.add(dictionary.readInteger(intList.get(i)));
+ resultList.add(intList.get(i) == null ? null :
dictionary.readInteger(intList.get(i)));
}
break;
case DATE:
case INTERVAL_YEAR_MONTH:
case LONG:
resultList = new ArrayList<Long>(total);
for (int i = 0; i < total; ++i) {
- resultList.add(dictionary.readLong(intList.get(i)));
+ resultList.add(intList.get(i) == null ? null :
dictionary.readLong(intList.get(i)));
}
break;
case BOOLEAN:
resultList = new ArrayList<Long>(total);
for (int i = 0; i < total; ++i) {
- resultList.add(dictionary.readBoolean(intList.get(i)) ? 1 : 0);
+ resultList.add(intList.get(i) == null ? null :
dictionary.readBoolean(intList.get(i)));
Review comment:
good catch, fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
