abstractdog commented on a change in pull request #2479:
URL: https://github.com/apache/hive/pull/2479#discussion_r690475398
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedListColumnReader.java
##########
@@ -323,7 +341,11 @@ private void
fillColumnVector(PrimitiveObjectInspector.PrimitiveCategory categor
int scale = logicalType.getScale();
lcv.child = new DecimalColumnVector(total, precision, scale);
for (int i = 0; i < valueList.size(); i++) {
- ((DecimalColumnVector) lcv.child).vector[i].set(((List<byte[]>)
valueList).get(i), scale);
+ if (valueList.get(i) == null) {
+ lcv.child.isNull[i] = true;
Review comment:
right, also compareDecimalColumnVector lacks some inner parentheses here
I guess :) I'll fix it
```
if (cv1.vector[i] != null && cv2.vector[i] == null
|| cv1.vector[i] == null && cv2.vector[i] != null
|| cv1.vector[i] != null && cv2.vector[i] != null &&
!cv1.vector[i].equals(cv2.vector[i])) {
```
needs to be ((... && ...) || (... && ...) || (... && ... && ...))
without parentheses it is a bit messy/undefined for me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
