kgyrtkirk commented on a change in pull request #2839:
URL: https://github.com/apache/hive/pull/2839#discussion_r761827358
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
##########
@@ -339,6 +339,11 @@ private void check(Filter filter) {
final RexNode filterCondition = simplify.simplify(filter.getCondition());
final Set<Integer> inputRefs =
HiveCalciteUtil.getInputRefs(newCondition);
+ // if the new IS NOT NULL has no input ref, there is redundancy here,
bail out
+ if (inputRefs.isEmpty()) {
+ return;
Review comment:
this rule doesn't look right to me right now with this
`isRedundantIsNotNull` call which:
* walks the entire rel tree
* invokes simplification on filter nodes
* unboxes HepRelVertex stuff
can we avoid the original issue of HIVE-25275 - by adding a rule which
targets expression simplication (reduceexpressionrule?) to the same rule-group?
can you open a ticket to investiage this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
