asinkovits commented on a change in pull request #2906:
URL: https://github.com/apache/hive/pull/2906#discussion_r782918861
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -164,7 +164,7 @@ public void run() {
for (CompactionInfo ci : potentials) {
try {
- Table t = resolveTable(ci);
+ Table t = resolveTableAndCache(ci);
Review comment:
I'm fine changing it to the suggested approach, just want to understand
the reasoning behind it.
I do have concerns introducing a hash map, as we have less control over the
memory pressure. Table objects are moderately large, and as you mentioned there
can be large clusters with numerous tables.
I was using softValues, so the cache can be cleared by the garbage collector
in response to memory demand.
As for no 2, do you see some use case where the current approach doesn't
address the observed issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
