deniskuzZ commented on a change in pull request #2906:
URL: https://github.com/apache/hive/pull/2906#discussion_r787524083
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -142,6 +145,7 @@ public void run() {
final ShowCompactResponse currentCompactions =
txnHandler.showCompact(new ShowCompactRequest());
+ metadataCache.ifPresent(c -> c.invalidateAll());
Review comment:
Could you please add a comment on why do we need to invalidate the cache
on every iteration and that's needs to be revisited later?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -142,6 +145,7 @@ public void run() {
final ShowCompactResponse currentCompactions =
txnHandler.showCompact(new ShowCompactRequest());
+ metadataCache.ifPresent(c -> c.invalidateAll());
Review comment:
Could you please add a comment on why do we need to invalidate the cache
on every iteration and that needs to be revisited later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
