rbalamohan commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r803827123
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -448,6 +448,20 @@ public boolean renameDir(Path sourcePath, Path destPath,
boolean needCmRecycle)
return false;
}
+ public boolean copyDir(Path sourcePath, Path destPath, boolean
needCmRecycle) throws MetaException {
+ try {
+ if (needCmRecycle) {
+ cm.recycle(sourcePath, RecycleType.COPY, true);
+ }
+ FileSystem srcFs = getFs(sourcePath);
+ FileSystem destFs = getFs(destPath);
+ return FileUtils.copy(srcFs, sourcePath, destFs, destPath, false, false,
conf);
Review comment:
minor comment. This can turn out to be expensive depending on size of
the directory, size and number of files. May be good to add a TODO for later
ref/fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
