pvary commented on a change in pull request #3015:
URL: https://github.com/apache/hive/pull/3015#discussion_r840825262
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2109,7 +2109,8 @@ struct RenamePartitionRequest {
3: required string tableName,
4: required list<string> partVals,
5: required Partition newPart,
- 6: optional string validWriteIdList
+ 6: optional string validWriteIdList,
+ 7: optional EnvironmentContext environmentContext
Review comment:
By my understanding - EnvironmentContext was the first solution for
extending the interface with new fields without adding new methods every time.
This solution evolved to the `...Request` objects later.
Since we have a `RenamePartitionRequest` already, it might be better to use
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
