deniskuzZ commented on a change in pull request #3034:
URL: https://github.com/apache/hive/pull/3034#discussion_r811757682
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java
##########
@@ -522,6 +522,16 @@ void onRename(String oldCatName, String oldDbName, String
oldTabName, String old
*/
void markRefused(CompactionInfo info) throws MetaException;
+ /**
+ * Updates the cleaner retry time related information (compaction properties
and commit time) of the CompactionInfo
+ * in the HMS database.
+ * @param info The {@link CompactionInfo} object to be updated.
+ * @param retentionTime The time until the clean won't be attempted again.
+ * @throws MetaException
+ */
+ @RetrySemantics.CannotRetry
+ void updateCompactionRetry(CompactionInfo info, long retentionTime) throws
MetaException;
Review comment:
method name doesn't conform to its declaration. should be something like
retryCleanerAttemptWithBackoff()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
