ayushtkn commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880726160
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -312,13 +312,11 @@ public void load(MapJoinTableContainer[] mapJoinTables,
inputName, cacheKey, receivedEntries, delta);
}
} catch (InterruptedException e) {
+ loadExecService.shutdownNow();
Review Comment:
There is :
```
loadExecService.awaitTermination(2, TimeUnit.MINUTES)
```
This just waits 2 minutes, doesn't throw any exception, if the tasks don't
get completed in 2 mins. Now if we waited 120 seconds and the task was supposed
to be completed in 122 seconds. We would interrupt the thread now in the
``finally`` block?
Won't the result or behaviour change post this change? say it had a chance
to complete before it gets terminated or so....
Or check for the return value of this awaitTermination and if it returns
false, we throw an Exception rather than a success, that way this finally block
might look cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
