pvary commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880805144
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -294,7 +295,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes
for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
- loadExecService.awaitTermination(2, TimeUnit.MINUTES);
+
+ if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ throw new HiveException("Failed to complete the hash table loader.
Loading timed out.");
Review Comment:
Catch and rethrow in the surrounding try-catch?,
```
} catch(HiveException he) {
throw he;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
