pvary commented on code in PR #2855:
URL: https://github.com/apache/hive/pull/2855#discussion_r885398457
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -470,8 +405,7 @@ private String handleUpdate(ASTNode
whenMatchedUpdateClause, StringBuilder rewri
rewrittenQueryStr.append(" AND
NOT(").append(deleteExtraPredicate).append(")");
}
if(!splitUpdateEarly) {
- rewrittenQueryStr.append("\n SORT BY ");
- rewrittenQueryStr.append(targetName).append(".ROW__ID ");
+ appendSortBy(rewrittenQueryStr, Collections.singletonList(targetName +
".ROW__ID "));
}
rewrittenQueryStr.append("\n");
Review Comment:
nit: Do we want to write out the whole query string in debug mode, so it is
easier to understand if there is an error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
