pvary commented on code in PR #2855:
URL: https://github.com/apache/hive/pull/2855#discussion_r885400801
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -267,9 +262,104 @@ private void reparseAndSuperAnalyze(ASTNode tree) throws
SemanticException {
}
}
- private void validateTxnManager(Table mTable) throws SemanticException {
- if (!AcidUtils.acidTableWithoutTransactions(mTable) &&
!getTxnMgr().supportsAcid()) {
- throw new SemanticException(ErrorMsg.ACID_OP_ON_NONACID_TXNMGR.getMsg());
+ private void analyzeSplitUpdate(ASTNode tree, Table mTable, ASTNode
tabNameNode) throws SemanticException {
+ operation = Context.Operation.UPDATE;
+
+ List<? extends Node> children = tree.getChildren();
+
+ ASTNode where = null;
+ int whereIndex = 2;
+ if (children.size() > whereIndex) {
+ where = (ASTNode) children.get(whereIndex);
+ assert where.getToken().getType() == HiveParser.TOK_WHERE :
+ "Expected where clause, but found " + where.getName();
+ }
+
+ Set<String> setRCols = new LinkedHashSet<>();
+// TOK_UPDATE_TABLE
+// TOK_TABNAME
+// ...
+// TOK_SET_COLUMNS_CLAUSE <- The set list from update should be the
second child (index 1)
+ assert children.size() >= 2 : "Expected update token to have at least two
children";
+ ASTNode setClause = (ASTNode) children.get(1);
+ Map<String, ASTNode> setCols = collectSetColumnsAndExpressions(setClause,
setRCols, mTable);
+ Map<Integer, ASTNode> setColExprs = new
HashMap<>(setClause.getChildCount());
+
+ List<FieldSchema> nonPartCols = mTable.getCols();
+ Map<String, String> colNameToDefaultConstraint =
getColNameToDefaultValueMap(mTable);
+ List<String> values = new ArrayList<>(mTable.getCols().size());
+ StringBuilder rewrittenQueryStr = createRewrittenQueryStrBuilder();
+ rewrittenQueryStr.append("(SELECT ROW__ID");
+ for (int i = 0; i < nonPartCols.size(); i++) {
+ rewrittenQueryStr.append(',');
+ String name = nonPartCols.get(i).getName();
+ ASTNode setCol = setCols.get(name);
+ String identifier = HiveUtils.unparseIdentifier(name, this.conf);
+
+ if (setCol != null) {
+ if (setCol.getType() == HiveParser.TOK_TABLE_OR_COL &&
+ setCol.getChildCount() == 1 && setCol.getChild(0).getType() ==
HiveParser.TOK_DEFAULT_VALUE) {
+ rewrittenQueryStr.append(colNameToDefaultConstraint.get(name));
+ } else {
+ rewrittenQueryStr.append(identifier);
+ // This is one of the columns we're setting, record it's position so
we can come back
+ // later and patch it up. 0th is ROW_ID
+ setColExprs.put(i + 1, setCol);
+ }
+ } else {
+ rewrittenQueryStr.append(identifier);
+ }
+ rewrittenQueryStr.append(" AS ");
+ rewrittenQueryStr.append(identifier);
+
+ values.add("s." + identifier);
+ }
+ addPartitionColsToSelect(mTable.getPartCols(), rewrittenQueryStr);
+ addPartitionColsAsValues(mTable.getPartCols(), "s", values);
+ rewrittenQueryStr.append(" FROM
").append(getFullTableNameForSQL(tabNameNode)).append(") s\n");
+
+ appendInsertBranch(rewrittenQueryStr, null, values);
+ appendDeleteBranch(rewrittenQueryStr, null, "s",
Collections.singletonList("s.ROW__ID "));
+
+ appendSortBy(rewrittenQueryStr, Collections.singletonList("s.ROW__ID "));
+
+ ReparseResult rr = parseRewrittenQuery(rewrittenQueryStr, ctx.getCmd());
+ Context rewrittenCtx = rr.rewrittenCtx;
+ ASTNode rewrittenTree = rr.rewrittenTree;
+
+ ASTNode rewrittenInsert = new ASTSearcher().simpleBreadthFirstSearch(
+ rewrittenTree, HiveParser.TOK_FROM, HiveParser.TOK_SUBQUERY,
HiveParser.TOK_INSERT);
+
+ rewrittenCtx.setOperation(Context.Operation.UPDATE);
+ rewrittenCtx.addDestNamePrefix(1, Context.DestClausePrefix.INSERT);
+ rewrittenCtx.addDeleteOfUpdateDestNamePrefix(2,
Context.DestClausePrefix.DELETE);
+
+ if (where != null) {
+ rewrittenInsert.addChild(where);
+ }
+
+ patchProjectionForUpdate(rewrittenInsert, setColExprs);
+
+ try {
Review Comment:
nit: Maybe here where we want to log out the resulting query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
