dengzhhu653 commented on code in PR #3221:
URL: https://github.com/apache/hive/pull/3221#discussion_r912900559
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java:
##########
@@ -1483,6 +1483,135 @@ public void testListPackage() throws Exception {
Assert.assertEquals(1, result.size());
}
+ @Test
+ public void testSerDeCreatedOnDemand() throws Exception {
+ // Enable USE_TABLE_SERDES
+ final boolean origUseTableSerDes = MetastoreConf.getBoolVar(conf,
ConfVars.USE_TABLE_SERDES);
+ if (!origUseTableSerDes) {
+ MetastoreConf.setBoolVar(conf, ConfVars.USE_TABLE_SERDES, true);
+ objectStore.setConf(conf);
+ }
+
+ createPartitionedTable(true, true);
+ // Partitions should reuse table's serde info
+ checkBackendTableSize("PARTITIONS", 3);
+ checkBackendTableSize("SERDES", 1);
+ checkBackendTableSize("SERDE_PARAMS", 1);
+ Table tbl;
+ Partition newPart;
+ // Alters table's serde info
+ try (AutoCloseable c = deadline()) {
+ tbl = objectStore.getTable(DEFAULT_CATALOG_NAME, DB1, TABLE1);
+ Table newTbl = tbl.deepCopy();
+ newTbl.getSd().getSerdeInfo().setDescription("To test SerDe is created
on demand");
+ objectStore.alterTable(DEFAULT_CATALOG_NAME, DB1, TABLE1, newTbl, null);
+ }
+ // A new SERDE should be created
+ checkBackendTableSize("SERDES", 2);
+ checkBackendTableSize("SERDE_PARAMS", 2);
+ // Alter a partition's serde info
+ List<String> partVals = Collections.singletonList("a0");
+ try (AutoCloseable c = deadline()) {
+ Partition part = objectStore.getPartition(DEFAULT_CATALOG_NAME, DB1,
TABLE1, partVals);
+ newPart = part.deepCopy();
+ newPart.getSd().getSerdeInfo().setDescription("To test SerDe is created
on demand");
+ objectStore.alterPartition(DEFAULT_CATALOG_NAME, DB1, TABLE1, partVals,
newPart, null);
+ }
+ // A new SERDE should be created
+ checkBackendTableSize("SERDES", 3);
+ checkBackendTableSize("SERDE_PARAMS", 3);
+ // Adds a partition with different serde
+ newPart.setValues(Collections.singletonList("a3"));
+ newPart.getSd().getSerdeInfo().setDescription("To test adding a partition
with different SerDe");
+ objectStore.addPartition(newPart);
+ // A new SERDE should be created
+ checkBackendTableSize("SERDES", 4);
+ checkBackendTableSize("SERDE_PARAMS", 4);
+
+ // Restore conf
+ if (!origUseTableSerDes) {
+ MetastoreConf.setBoolVar(conf, ConfVars.USE_TABLE_SERDES, false);
+ objectStore.setConf(conf);
+ }
+ }
+
+ @Test
+ public void testSerDesCleanup() throws Exception {
+ // Enable USE_TABLE_SERDES
+ final boolean origUseTableSerDes = MetastoreConf.getBoolVar(conf,
ConfVars.USE_TABLE_SERDES);
+ if (!origUseTableSerDes) {
+ MetastoreConf.setBoolVar(conf, ConfVars.USE_TABLE_SERDES, true);
+ objectStore.setConf(conf);
+ }
+
+ createPartitionedTable(true, true);
+ // Partitions should reuse table's serde info
+ checkBackendTableSize("PARTITIONS", 3);
+ checkBackendTableSize("SERDES", 1);
+ checkBackendTableSize("SERDE_PARAMS", 1);
+ // Alters a partition's serde info
+ List<String> partVals = Collections.singletonList("a0");
+ Partition newPart;
+ try (AutoCloseable c = deadline()) {
+ Partition part = objectStore.getPartition(DEFAULT_CATALOG_NAME, DB1,
TABLE1, partVals);
+ newPart = part.deepCopy();
Review Comment:
could we check the serde info before and after the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
