saihemanth-cloudera commented on code in PR #3221:
URL: https://github.com/apache/hive/pull/3221#discussion_r924540635
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -2635,10 +2634,9 @@ private void dropPartitionsByPartitionIds(List<Long>
partitionIdList) throws Met
for (Object[] fields : sqlResult) {
sdIdList.add(MetastoreDirectSqlUtils.extractSqlLong(fields[0]));
Long colId = MetastoreDirectSqlUtils.extractSqlLong(fields[1]);
- if (!columnDescriptorIdList.contains(colId)) {
- columnDescriptorIdList.add(colId);
- }
- serdeIdList.add(MetastoreDirectSqlUtils.extractSqlLong(fields[2]));
+ columnDescriptorIdSet.add(colId);
+ Long serdeId = MetastoreDirectSqlUtils.extractSqlLong(fields[2]);
+ serdeIdSet.add(serdeId);
Review Comment:
Can you directly add the Long variable to the set instead of creating a
'serdeId' variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
