zhangbutao commented on PR #3393:
URL: https://github.com/apache/hive/pull/3393#issuecomment-1207815099

   @zabetak After further investigation, i found HIVE-22526 separateed txn 
related codes from compile codes which lead to exception(errorCode 10264) from 
txn not being catched and converted into `CommandProcessorException`. I fixed 
this regression by catch txn exception in txn code block. 
   
   After fixing, we can get txn exception whth errorCode(10264) and 
state(42000).
   `Error: Error while compiling statement: FAILED: RuntimeException [Error 
10264]: To use DbTxnManager you must set hive.support.concurrency=true 
(state=42000,code=10264)`
   
   BTW, for other exception which may not exist in` ErrorMsg class`,  shoud we 
add a generic error code in `ErrorMsg class` or simply throw message? I have 
seen lots of code which handle `HiveSQLException` like this:
   `throw new HiveSQLException("Error running query: " + e.toString(), e);`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to