zabetak commented on code in PR #3393:
URL: https://github.com/apache/hive/pull/3393#discussion_r974185170
##########
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:
##########
@@ -511,13 +511,17 @@ public void compile(String command, boolean resetTaskIds,
boolean deferClose) th
}
private void prepareForCompile(boolean resetTaskIds) throws
CommandProcessorException {
- driverTxnHandler.createTxnManager();
- DriverState.setDriverState(driverState);
- prepareContext();
- setQueryId();
+ try {
Review Comment:
I suppose that this try-catch block was introduced to address the [so-called
regression](https://github.com/apache/hive/pull/3393#issuecomment-1207815099)
from HIVE-22526 but I don't fully understand where the regression comes from.
I had a quick look in the diff introduced by HIVE-22526 but as far as I can
see there the`driverTxnHandler#createTxnManager` is not wrapped in a try-catch
block and it seems that the exception is not passed in `handleException`
method. @zhangbutao can you explain a bit more on where exactly is the
regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
