deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1026168632
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:
##########
@@ -1823,6 +1831,22 @@ private int getBucketProperty(Object row) {
}
}
+ /**
+ * Reuired for rebalancing compaction. Encodes the raw bucket property set
by the compactor
+ * @param row The acid row in which the bucket needs to be updated.
+ */
+ private void setBucketProperty(Configuration hiveConf, Object row, int
bucketId) {
+ //TODO: statementId?
+ BucketCodec codec = conf.getBucketingVersion() == 2 ? BucketCodec.V1 :
BucketCodec.V0;
Review Comment:
haven't seen in a code BucketCodec.V0 being used for acid, do we need this?
````
BucketCodec.V1.encode(new
AcidOutputFormat.Options(hiveConf).bucket(bucketId))
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
