veghlaci05 commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1026179515
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -493,7 +494,7 @@ public static boolean isCompactionTable(Properties
tblProperties) {
* @return true, if the parameters contains {@link
AcidUtils#COMPACTOR_TABLE_PROPERTY}
*/
public static boolean isCompactionTable(Map<String, String> parameters) {
- return Boolean.parseBoolean(parameters.get(COMPACTOR_TABLE_PROPERTY));
+ return StringUtils.isNotBlank(parameters.get(COMPACTOR_TABLE_PROPERTY));
Review Comment:
It is set only by the
[CompactionQueryBuilder](https://github.com/apache/hive/blob/e3751ab545370f9b252d0b4a07bc315037541a95/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java),
and from now on it is setting the compaction type instead of `true/false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
