asolimando commented on code in PR #3137:
URL: https://github.com/apache/hive/pull/3137#discussion_r1039333194
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/BinaryColumnStatsAggregator.java:
##########
@@ -60,4 +60,8 @@ public ColumnStatisticsObj
aggregate(List<ColStatsObjWithSourceInfo> colStatsWit
statsObj.setStatsData(columnStatisticsData);
return statsObj;
}
+
+ @Override protected ColumnStatisticsData initColumnStatisticsData() {
+ throw new UnsupportedOperationException("initColumnStatisticsData not
supported for binary statistics");
Review Comment:
You are right, the method does not do much for `binary` and `boolean`, but
it still make sense, so I have:
- removed the exception, replaced with `return new ColumnStatisticsData();`
- used the method to actually initialize the emtpy `ColumnStatisticsData`
for those two data types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
