asolimando commented on code in PR #3137:
URL: https://github.com/apache/hive/pull/3137#discussion_r1040578295
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/columnstats/ColStatsBuilder.java:
##########
@@ -103,6 +105,12 @@ public ColStatsBuilder<T> hll(String... values) {
return this;
}
+ public ColStatsBuilder<T> hll(double... values) {
+ HyperLogLog hll = StatisticsTestUtils.createHll(values);
+ this.bitVector = hll.serialize();
Review Comment:
No, HLL is different from KLL, it's used for counting distinct values, the
method naming is different because HLL has a in-house implementation in Hive
while KLL comes from Apache datasketches library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
