scarlin-cloudera commented on code in PR #4174:
URL: https://github.com/apache/hive/pull/4174#discussion_r1153811990


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -888,7 +888,7 @@ public void cleanEmptyAbortedAndCommittedTxns() throws 
MetaException {
           */
         long lowWaterMark = getOpenTxnTimeoutLowBoundaryTxnId(dbConn);
 
-        String s = "SELECT \"TXN_ID\" FROM \"TXNS\" WHERE " +
+        String s = "DELETE \"TXN_ID\" FROM \"TXNS\" WHERE " +

Review Comment:
   Do the delete Ids get returned in the result set of executeQuery?  Can we 
delete the rest of the code that collects these Ids and then appears to delete 
them ( a second time)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to