maheshrajus commented on code in PR #4174:
URL: https://github.com/apache/hive/pull/4174#discussion_r1182127027
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -875,7 +875,6 @@ public void cleanEmptyAbortedAndCommittedTxns() throws
MetaException {
try {
Connection dbConn = null;
Statement stmt = null;
- ResultSet rs = null;
Review Comment:
Hi @deniskuzZ thx for review.
we are not just closing the db connection in finally block, we are doing
rollback in catch block( rollbackDBConn(dbConn)).
I think try-with-resource may not work in this case. So i am keeping try
block code only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
