deniskuzZ commented on code in PR #4174:
URL: https://github.com/apache/hive/pull/4174#discussion_r1183331418
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -926,10 +900,8 @@ public void cleanEmptyAbortedAndCommittedTxns() throws
MetaException {
checkRetryable(e, "cleanEmptyAbortedTxns");
throw new MetaException("Unable to connect to transaction database " +
e.getMessage());
- } finally {
- close(rs, stmt, dbConn);
}
- } catch (RetryException e) {
+ } catch (RetryException | SQLException e) {
Review Comment:
SQLException from getDbConn() is not checked for being Retryable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
