scarlin-cloudera commented on code in PR #4378:
URL: https://github.com/apache/hive/pull/4378#discussion_r1222066641


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/type/FunctionHelper.java:
##########
@@ -78,6 +79,12 @@ AggregateInfo getWindowAggregateFunctionInfo(boolean 
isDistinct, boolean isAllCo
       String aggregateName, List<RexNode> aggregateParameters)
       throws SemanticException;
 
+  /**
+   * Returns RexCall for UDTF based on given parameters
+   */
+  RexCall getUDTFFunction(String functionName, List<RexNode> operands)

Review Comment:
   I hope I made the change you wanted.  It already mentioned returning a 
RexCall, but didn't mention anything about getting it from the 
FunctionRegistry. Although I want to be careful not explicitly mentioned 
FunctionRegistry because this is an interface and can be theoretically 
overridden by a third party implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to