dengzhhu653 commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1223936901
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -528,6 +533,7 @@ public static void updateTableStatsForCreateTable(Warehouse
wh, Database db, Tab
StatsSetupConst.ColumnStatsSetup statsSetup =
StatsSetupConst.ColumnStatsSetup.parseStatsSetup(val);
if (statsSetup.enabled) {
try {
+ isIcebergTable = statsSetup.isIcebergTable;
// For an Iceberg table, a new snapshot is generated, so any
leftover files would be ignored
// Set the column stats true in order to make it merge-able
if (newDir || statsSetup.isIcebergTable ||
Review Comment:
If the current table is an Iceberg, then it will populate all the fast stats
into table,
https://github.com/apache/hive/blob/6b095edc31a9baa0ae805e2b5aea88101284d84b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java#L539
https://github.com/apache/hive/blob/6b095edc31a9baa0ae805e2b5aea88101284d84b/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java#L401-L405
As a result, the pre-condition in `updateTableStatsSlow` should be true,
will ignore iterating the files under the table's directory.
https://github.com/apache/hive/blob/6b095edc31a9baa0ae805e2b5aea88101284d84b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java#L453-L456
am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
