dengzhhu653 commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1223948022
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2205,7 +2206,7 @@ public static enum ConfVars {
"padding tolerance config (hive.exec.orc.block.padding.tolerance)."),
HIVE_ORC_CODEC_POOL("hive.use.orc.codec.pool", false,
"Whether to use codec pool in ORC. Disable if there are bugs with
codec reuse."),
- HIVE_ICEBERG_STATS_SOURCE("hive.iceberg.stats.source", "iceberg",
+ HIVE_ICEBERG_STATS_SOURCE(StatsSetupConst.HIVE_ICEBERG_STATS_SOURCE,
"iceberg",
Review Comment:
nit: Maybe we can change the `StatsSetupConst.HIVE_ICEBERG_STATS_SOURCE` to
`hive.iceberg.stats.source`, though it can pass the compilation, but making the
hive-common independent from hive-standalone-metastore-common is important.
Could we move this property to MetastoreConf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
