deniskuzZ commented on code in PR #4426:
URL: https://github.com/apache/hive/pull/4426#discussion_r1233861860
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1381,6 +1381,11 @@ public void
setTableParametersForCTLT(org.apache.hadoop.hive.ql.metadata.Table t
SessionStateUtil.addResourceOrThrow(conf,
hive_metastoreConstants.PARTITION_TRANSFORM_SPEC, spec);
tbl.getSd().getCols().addAll(tbl.getPartitionKeys());
tbl.getTTable().setPartitionKeysIsSet(false);
+
+ // Remove any transactional properties as they aren't relevant in case
of iceberg tables.
+ tbl.getParameters().keySet().removeIf(
+ key ->
hive_metastoreConstants.TABLE_IS_TRANSACTIONAL.equalsIgnoreCase(key) ||
+
hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES.equalsIgnoreCase(key));
Review Comment:
should we filter out
`hive_metastoreConstants.TABLE_TRANSACTIONAL_PROPERTIES` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
