deniskuzZ commented on code in PR #4426:
URL: https://github.com/apache/hive/pull/4426#discussion_r1236762583
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -13967,7 +13968,8 @@ ASTNode analyzeCreateTable(
isTransactional, isManaged, new String[]{qualifiedTabName.getDb(),
qualifiedTabName.getTable()}, isDefaultTableTypeChanged);
tblProps.put(hive_metastoreConstants.TABLE_IS_CTLT, "true");
- isExt = isExternalTableChanged(tblProps, isTransactional, isExt,
isDefaultTableTypeChanged);
+ isExt = isIcebergTable(tblProps) ||
+ isExternalTableChanged(tblProps, isTransactional, isExt,
isDefaultTableTypeChanged);
Review Comment:
could we please move `isIcebergTable(tblProps)` check inside of
isExternalTableChanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
