deniskuzZ commented on code in PR #4392:
URL: https://github.com/apache/hive/pull/4392#discussion_r1234867175
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -347,6 +347,18 @@ public StorageFormatDescriptor
getStorageFormatDescriptor(org.apache.hadoop.hive
return null;
}
+ public boolean supportsAppendData(org.apache.hadoop.hive.metastore.api.Table
table) throws SemanticException {
+ Table icebergTbl = IcebergTableUtil.getTable(conf, table);
+ return icebergTbl.spec().isUnpartitioned();
+ }
+
+ public void appendFiles(org.apache.hadoop.hive.metastore.api.Table table,
URI fromURI, boolean isOverwrite)
+ throws SemanticException {
+ Table icebergTbl = IcebergTableUtil.getTable(conf, table);
+ String format = table.getParameters().get("write.format.default");
Review Comment:
could we please move `write.format.default` to constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
