deniskuzZ commented on code in PR #4392:
URL: https://github.com/apache/hive/pull/4392#discussion_r1236794810
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java:
##########
@@ -1059,7 +1073,13 @@ public boolean canExecuteInParallel() {
* @return Returns <code>true</code> if the commit was successfully executed
* @throws HiveException If we tried to commit, but there was an error
during the process
*/
- private static boolean checkAndCommitNatively(MoveWork moveWork,
Configuration configuration) throws HiveException {
+ private boolean checkAndCommitNatively(MoveWork moveWork, Configuration
configuration) throws HiveException {
+
+ Integer x = executeIcebergLoad();
Review Comment:
Could we just embed this logic so it won't be iceberg specific?
````
LoadTableDesc loadTableWork = moveWork.getLoadTableWork();
if (loadTableWork != null) {
if (loadTableWork.isUseAppendForLoad()) {
loadTableWork.getMdTable().getStorageHandler()
.appendFiles(loadTableWork.getMdTable().getTTable(),
loadTableWork.getSourcePath().toUri(),
loadTableWork.getLoadFileType() == LoadFileType.REPLACE_ALL);
return true;
}
// Get the info from the table data
TableDesc tableDesc = loadTableWork.getTable();
storageHandlerClass = tableDesc.getProperties().getProperty(
org.apache.hadoop.hive.metastore.api.hive_metastoreConstants.META_TABLE_STORAGE);
commitProperties = new Properties(tableDesc.getProperties());
overwrite = loadTableWork.isInsertOverwrite();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
