deniskuzZ commented on code in PR #4372:
URL: https://github.com/apache/hive/pull/4372#discussion_r1247812468
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/metaref/AlterTableCreateMetaRefAnalyzer.java:
##########
@@ -57,90 +59,55 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
DDLUtils.validateTableIsIceberg(table);
inputs.add(new ReadEntity(table));
validateAlterTableType(table, alterTableType, false);
- AlterTableTypeReq alterTableTypeReq = new AlterTableTypeReq();
String metaRefName = command.getChild(0).getText();
- alterTableTypeReq.tableName = tableName;
- alterTableTypeReq.metaRefName = metaRefName;
Long snapshotId = null;
Long asOfTime = null;
Long maxRefAgeMs = null;
Integer minSnapshotsToKeep = null;
Long maxSnapshotAgeMs = null;
AlterTableType alterTableType = command.getType()
Review Comment:
why do you need this? alterTableType is set in children
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
