deniskuzZ commented on code in PR #4372: URL: https://github.com/apache/hive/pull/4372#discussion_r1258194401
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/snapshotref/AlterTableCreateSnapshotRefAnalyzer.java: ########## @@ -16,50 +16,48 @@ * limitations under the License. */ -package org.apache.hadoop.hive.ql.ddl.table.branch.create; +package org.apache.hadoop.hive.ql.ddl.table.snapshotref; import java.time.ZoneId; import java.util.Locale; import java.util.Map; import java.util.concurrent.TimeUnit; - import org.apache.hadoop.hive.common.TableName; import org.apache.hadoop.hive.common.type.TimestampTZ; import org.apache.hadoop.hive.common.type.TimestampTZUtil; import org.apache.hadoop.hive.conf.HiveConf; import org.apache.hadoop.hive.ql.QueryState; -import org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory; import org.apache.hadoop.hive.ql.ddl.DDLUtils; import org.apache.hadoop.hive.ql.ddl.DDLWork; import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableAnalyzer; +import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableDesc; import org.apache.hadoop.hive.ql.ddl.table.AlterTableType; import org.apache.hadoop.hive.ql.exec.TaskFactory; import org.apache.hadoop.hive.ql.hooks.ReadEntity; import org.apache.hadoop.hive.ql.metadata.Table; import org.apache.hadoop.hive.ql.parse.ASTNode; -import org.apache.hadoop.hive.ql.parse.AlterTableBranchSpec; +import org.apache.hadoop.hive.ql.parse.AlterTableSnapshotRefSpec; import org.apache.hadoop.hive.ql.parse.HiveParser; import org.apache.hadoop.hive.ql.parse.SemanticException; import org.apache.hadoop.hive.ql.session.SessionState; -import static org.apache.hadoop.hive.ql.parse.AlterTableBranchSpec.AlterBranchOperationType.CREATE_BRANCH; - [email protected](types = HiveParser.TOK_ALTERTABLE_CREATE_BRANCH) -public class AlterTableCreateBranchAnalyzer extends AbstractAlterTableAnalyzer { +public abstract class AlterTableCreateSnapshotRefAnalyzer extends AbstractAlterTableAnalyzer { + protected static AbstractAlterTableDesc alterTableDesc; Review Comment: remove `protected` & `static`, add `private` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
