akshat0395 commented on code in PR #4475:
URL: https://github.com/apache/hive/pull/4475#discussion_r1262719536
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/HiveDatabaseAccessor.java:
##########
@@ -56,4 +57,19 @@ protected String addLimitToQuery(String sql, int limit) {
}
return sql + " LIMIT " + limit;
}
+
+ @Override
+ protected List<String> getColNamesFromRS(ResultSet rs) throws Exception {
+ List<String> columnNames = super.getColNamesFromRS(rs);
+ return columnNames.stream()
+ .map(c -> {
+ int lastIndex = c.lastIndexOf(".");
+ return lastIndex == -1 ? c : c.substring(lastIndex + 1); })
+ .collect(Collectors.toList());
+ }
+
+ @Override
+ protected String getMetaDataQuery(String sql) {
+ return addLimitToQuery(sql, 0);
Review Comment:
wont limit 0 return an empty set? why is this needed?
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java:
##########
@@ -108,59 +143,34 @@ private <T> List<T> getColumnMetadata(Configuration conf,
ColumnMetadataAccessor
}
+ private <T> List<T> getColumnMetadata(ResultSet rs,
ColumnMetadataAccessor<T> colAccessor)
Review Comment:
Do we really need this method? we already have getColumnMetadata. I like the
idea of making methods smaller and more comprehensive, in this case I feel we
dont really need this method.
This also introduces a need to throw a generic exception instead a specific
one which should be avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
