dengzhhu653 commented on code in PR #4475: URL: https://github.com/apache/hive/pull/4475#discussion_r1263227449
########## jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java: ########## @@ -108,59 +143,34 @@ private <T> List<T> getColumnMetadata(Configuration conf, ColumnMetadataAccessor } + private <T> List<T> getColumnMetadata(ResultSet rs, ColumnMetadataAccessor<T> colAccessor) Review Comment: There are some places need to extract the result metadata from ResultSet, https://github.com/apache/hive/blob/a838ca2760799708c465051904b96cab4ae628d1/jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java#L69-L70 https://github.com/apache/hive/blob/a838ca2760799708c465051904b96cab4ae628d1/jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java#L135 Method is declared as private, the upper caller will deal with the specific exception. For example: https://github.com/apache/hive/blob/a838ca2760799708c465051904b96cab4ae628d1/jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java#L250-L254 https://github.com/apache/hive/blob/a838ca2760799708c465051904b96cab4ae628d1/jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java#L81-L84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
