henrib commented on code in PR #4537:
URL: https://github.com/apache/hive/pull/4537#discussion_r1280593559
##########
jdbc/src/java/org/apache/hive/jdbc/saml/HiveJdbcBrowserClient.java:
##########
@@ -200,10 +206,47 @@ private Map<String, String> getQueryParams(URI ssoUri)
return paramMap;
}
+ /**
+ * The pattern for valid urls (http/s).
+ */
+ private static final Pattern VALID_URL = createValidUrlPattern();
+ private static Pattern createValidUrlPattern() {
+ final String validURLPattern =
Review Comment:
I thought about pushing the control up but I did not want to disrupt current
error handling. Let me try harder and see. As for the regex, it may be overkill
but it tries hard to ensure nothing 'extraordinary' appears in that URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
