nrg4878 commented on code in PR #4537:
URL: https://github.com/apache/hive/pull/4537#discussion_r1283470560
##########
jdbc/src/java/org/apache/hive/jdbc/saml/HiveJdbcBrowserClient.java:
##########
@@ -212,18 +213,19 @@ protected void openBrowserWindow() throws
HiveJdbcBrowserException {
LOG.info(
"Desktop mode is not supported. Attempting to use OS "
+ "commands to open the default browser");
+ String ssoUriStr = ssoUri.toString();
Review Comment:
potential for NPE given we took out the null check above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
